fix: 调试发布run

2026-07-22 11:44:48 +08:00
parent b06623d0ce
commit 6c3eb6e45f
41 changed files with 1289 additions and 206 deletions
@@ -414,6 +414,105 @@ func TestCoreServiceScopesServerAccessAndMembership(t *testing.T) {
 	}
 }

+func TestCoreServiceDeletesServerInstancesWithPasswordConfirmation(t *testing.T) {
+	svc := newTestCoreService()
+	plugin, endpoint := createPluginAndRunEndpoint(t, svc)
+	ownerSession := createServiceUserAndLogin(t, svc, domain.User{
+		ID:           "user-delete-owner",
+		DisplayName:  "Delete Owner",
+		Email:        "delete-owner@example.test",
+		Roles:        []string{"server-owner"},
+		PasswordHash: "secret-password",
+	})
+	adminSession := createServiceUserAndLogin(t, svc, domain.User{
+		ID:           "user-delete-admin",
+		DisplayName:  "Delete Admin",
+		Email:        "delete-admin@example.test",
+		Roles:        []string{"platform-admin"},
+		PasswordHash: "secret-password",
+	})
+	otherSession := createServiceUserAndLogin(t, svc, domain.User{
+		ID:           "user-delete-other",
+		DisplayName:  "Delete Other",
+		Email:        "delete-other@example.test",
+		Roles:        []string{"server-admin"},
+		PasswordHash: "secret-password",
+	})
+
+	ownerInstance, err := svc.CreateServerInstanceForSession(ownerSession, domain.ServerInstance{
+		ID:            "server-delete-owner",
+		PluginID:      plugin.ID,
+		RunEndpointID: endpoint.ID,
+		Name:          "Delete Owner Server",
+		State:         domain.ServerInstanceStateReady,
+	})
+	if err != nil {
+		t.Fatalf("create owner instance: %v", err)
+	}
+	adminTarget, err := svc.CreateServerInstanceForSession(ownerSession, domain.ServerInstance{
+		ID:            "server-delete-admin",
+		PluginID:      plugin.ID,
+		RunEndpointID: endpoint.ID,
+		Name:          "Delete Admin Target",
+		State:         domain.ServerInstanceStateReady,
+	})
+	if err != nil {
+		t.Fatalf("create admin target: %v", err)
+	}
+	runningTarget, err := svc.CreateServerInstanceForSession(ownerSession, domain.ServerInstance{
+		ID:            "server-delete-running",
+		PluginID:      plugin.ID,
+		RunEndpointID: endpoint.ID,
+		Name:          "Delete Running Target",
+		State:         domain.ServerInstanceStateReady,
+	})
+	if err != nil {
+		t.Fatalf("create running target: %v", err)
+	}
+	runningTarget.State = domain.ServerInstanceStateRunning
+	if err := svc.store.ServerInstances().Update(runningTarget); err != nil {
+		t.Fatalf("set running target state: %v", err)
+	}
+
+	if _, err := svc.DeleteServerInstanceForSession(otherSession, ownerInstance.ID, "secret-password"); !errors.Is(err, ErrForbidden) {
+		t.Fatalf("expected non-owner delete to be forbidden, got %v", err)
+	}
+	if _, err := svc.DeleteServerInstanceForSession(ownerSession, ownerInstance.ID, ""); err == nil {
+		t.Fatalf("expected missing password to fail")
+	} else {
+		var validationErr validator.ValidationError
+		if !errors.As(err, &validationErr) {
+			t.Fatalf("expected missing password to be validation error, got %v", err)
+		}
+	}
+	if _, err := svc.DeleteServerInstanceForSession(ownerSession, ownerInstance.ID, "wrong-password"); !errors.Is(err, ErrForbidden) {
+		t.Fatalf("expected wrong password to be forbidden, got %v", err)
+	}
+
+	deletedOwner, err := svc.DeleteServerInstanceForSession(ownerSession, ownerInstance.ID, "secret-password")
+	if err != nil {
+		t.Fatalf("delete owner instance: %v", err)
+	}
+	if deletedOwner.State != domain.ServerInstanceStateDeleted {
+		t.Fatalf("expected deleted owner state, got %+v", deletedOwner)
+	}
+	deletedAdmin, err := svc.DeleteServerInstanceForSession(adminSession, adminTarget.ID, "secret-password")
+	if err != nil {
+		t.Fatalf("delete admin target: %v", err)
+	}
+	if deletedAdmin.State != domain.ServerInstanceStateDeleted {
+		t.Fatalf("expected deleted admin state, got %+v", deletedAdmin)
+	}
+	if _, err := svc.DeleteServerInstanceForSession(ownerSession, runningTarget.ID, "secret-password"); err == nil {
+		t.Fatalf("expected running instance delete to fail")
+	} else {
+		var validationErr validator.ValidationError
+		if !errors.As(err, &validationErr) {
+			t.Fatalf("expected running delete to be validation error, got %v", err)
+		}
+	}
+}
+
 func TestCoreServiceMetricsAndConfigReadAreRoleScoped(t *testing.T) {
 	svc := newTestCoreService()
 	plugin, endpoint := createPluginAndRunEndpoint(t, svc)