admin343/browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

first commit

Browse Source
This commit is contained in:
npc0-hue
2026-07-11 14:56:10 +08:00
commit 7e05d0a4e7
660 changed files with 78119 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
openspec/changes/implement-config-write-and-file-dispatch/tasks.md
+58
View File
@@ -0,0 +1,58 @@
## 1. Config Diff Review Contracts
- [x] 1.1 Add domain contracts for config diff review, proposed content, approval status, and dispatch metadata.
- [x] 1.2 Add DTO contracts for config diff preview, approval, rejection, and dispatch responses.
- [x] 1.3 Add validators for bounded config size, allowed file keys, expected config version, and diff content safety.
- [x] 1.4 Add service methods for previewing and approving config writes without exposing host paths.
## 2. File Operation Dispatch Contracts
- [x] 2.1 Add domain/DTO contracts for scoped file read/write requests.
- [x] 2.2 Map file operations to platform job capabilities such as `config.write`, `files.read`, and `files.write`.
- [x] 2.3 Enforce plugin/server permissions and role-scoped server access before dispatch.
- [x] 2.4 Ensure dispatch payloads use logical file keys or artifact/input refs, not raw host paths.
## 3. Backend API Surface
- [x] 3.1 Implement config diff preview route for a server instance.
- [x] 3.2 Implement config write approval route that queues a bounded run job.
- [x] 3.3 Implement file operation dispatch route for scoped plugin/platform file jobs.
- [x] 3.4 Update route/protocol documentation to mark config and file dispatch implemented.
## 4. Frontend Integration
- [x] 4.1 Update ServerDetailPage config write flow to call config diff preview API.
- [x] 4.2 Update confirmation flow to call config write approval API instead of creating a generic job directly.
- [x] 4.3 Keep explicit second confirmation before dispatching any config write.
- [x] 4.4 Remove local-only config mutation after job dispatch; show pending platform job state instead.
## 5. Run Integration Prep
- [x] 5.1 Extend run protocol job payloads to carry scoped config/file input refs.
- [x] 5.2 Add run-side validation for allowed logical paths and bounded write payloads.
- [x] 5.3 Add tests proving raw host paths and credentials are rejected.
## 6. Verification
- [x] 6.1 Add platform tests for preview, approval, stale config version, unauthorized server access, and unsafe paths.
- [x] 6.2 Add frontend tests for diff preview, approval, failure, and no local mutation on dispatch.
- [x] 6.3 Run platform, run, and platform_web test/build commands and record evidence.
- [x] 6.4 Run browser walkthrough for config diff and write approval.
- [x] 6.5 Run `scripts/check-structure.sh` and record evidence.
- [x] 6.6 Run `openspec validate implement-config-write-and-file-dispatch --strict` and record evidence.
## Evidence
- 2026-07-06: `cd platform && go test ./domain ./dto ./validator ./service ./api ./model` passed after adding config diff/write contracts, validators, service methods, and API handlers.
- 2026-07-06: `cd run && go test ./protocol` passed after adding scoped job target/input refs and run protocol validation tests for raw host paths and raw credential refs.
- 2026-07-06: Updated `platform/api/routes.md`, `platform/protocol/server-lifecycle.md`, `run/protocol/job.md`, and `platform_web/api/contracts.md` to document implemented config diff/approval and scoped file dispatch routes/protocol payloads.
- 2026-07-06: `cd platform && go test ./service ./api -run 'TestCoreServiceConfigWriteAndFileDispatchAreScoped|TestConfigWriteAndFileDispatchAPIAreScoped'` passed, covering preview, approval, stale config version, unauthorized access, unsafe keys, and scoped file dispatch.
- 2026-07-06: `cd platform_web && npm run typecheck` passed after adding config diff/approval/file dispatch API types and client methods.
- 2026-07-06: `cd platform_web && npm test -- --run api/client.test.ts pages/ServerDetailPage.test.tsx` passed, covering preview/approval client requests, preview failure surfacing, platform diff mapping, no generic `config.write` job creation, and no local config mutation after approval dispatch.
- 2026-07-06: `cd platform && go test ./...` passed.
- 2026-07-06: `cd run && go test ./...` passed.
- 2026-07-06: `cd platform_web && npm test` passed with 11 files / 40 tests.
- 2026-07-06: `cd platform_web && npm run build` passed.
- 2026-07-06: Browser walkthrough passed using local platform `127.0.0.1:18090`, Vite `127.0.0.1:5177`, and headless Chrome: logged in, opened `#/servers/server-walkthrough`, edited config, previewed the platform diff, confirmed approval dispatch, saw the returned `config.write` job badge, and verified no `/Users/`, `unix://`, bearer token, raw key, password, or billing fragments were visible.
- 2026-07-06: `scripts/check-structure.sh` passed.
- 2026-07-06: `openspec validate implement-config-write-and-file-dispatch --strict` reported `Change 'implement-config-write-and-file-dispatch' is valid`; PostHog telemetry flush failed due restricted DNS and did not affect validation.