Keep run logs opaque and streamline transfers
This commit is contained in:
@@ -30,14 +30,14 @@ func TestLoadPackageConfigAppliesServerScopedIdentity(t *testing.T) {
|
||||
if cfg.RegistrationToken != "opaque-runtime-key" || cfg.RunEndpointID != "run-server-1" || cfg.ServerInstanceID != "server-1" || cfg.ComponentKey != "" || cfg.KeyGeneration != 3 {
|
||||
t.Fatalf("expected package identity to be applied, got %+v", cfg)
|
||||
}
|
||||
diagnostics := pkg.RedactedDiagnostics()
|
||||
diagnostics := pkg.IdentityDiagnostics()
|
||||
for _, value := range diagnostics {
|
||||
if strings.Contains(value, "opaque-runtime-key") || strings.Contains(value, "/Users/") || strings.Contains(value, "password=") {
|
||||
t.Fatalf("diagnostics exposed sensitive value: %+v", diagnostics)
|
||||
}
|
||||
}
|
||||
if diagnostics["keyFingerprint"] == "" || diagnostics["secretRef"] != "secret://runtime-keys/server-1/run/current" {
|
||||
t.Fatalf("expected redacted key fingerprint and secret ref, got %+v", diagnostics)
|
||||
t.Fatalf("expected key fingerprint and logical secret ref, got %+v", diagnostics)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -56,8 +56,7 @@ func TestLoadPackageConfigRejectsUnsafeOrIncompletePackages(t *testing.T) {
|
||||
"old zero generation": func(cfg PackageConfig) PackageConfig { cfg.KeyGeneration = 0; return cfg },
|
||||
"raw path": func(cfg PackageConfig) PackageConfig { cfg.ServerInstanceID = "/Users/tasia/server"; return cfg },
|
||||
"socket": func(cfg PackageConfig) PackageConfig { cfg.SecretRef = "unix:///tmp/run.sock"; return cfg },
|
||||
"secret auth": func(cfg PackageConfig) PackageConfig { cfg.AuthKey = "password=raw"; return cfg },
|
||||
"client missing key": func(cfg PackageConfig) PackageConfig { cfg.Kind = PackageComponentClientManager; return cfg },
|
||||
"legacy component": func(cfg PackageConfig) PackageConfig { cfg.Kind = "client-manager"; return cfg },
|
||||
}
|
||||
for name, mutate := range cases {
|
||||
if err := ValidatePackageConfig(mutate(valid)); err == nil {
|
||||
@@ -66,6 +65,22 @@ func TestLoadPackageConfigRejectsUnsafeOrIncompletePackages(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestPackageConfigTreatsAuthKeyAsOpaqueValue(t *testing.T) {
|
||||
cfg := PackageConfig{
|
||||
Kind: PackageComponentRun,
|
||||
ServerInstanceID: "server-1",
|
||||
PluginID: "game.scum",
|
||||
TargetOS: "windows",
|
||||
TargetArch: "amd64",
|
||||
SecretRef: "secret://runtime-keys/server-1/run/current",
|
||||
KeyGeneration: 1,
|
||||
AuthKey: "password=raw sk-test-value bearer literal",
|
||||
}
|
||||
if err := ValidatePackageConfig(cfg); err != nil {
|
||||
t.Fatalf("authKey must be treated as opaque package data, got %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAuthenticatePackageGenerationRejectsStalePackages(t *testing.T) {
|
||||
pkg := PackageConfig{
|
||||
Kind: PackageComponentRun,
|
||||
@@ -102,15 +117,16 @@ func TestAuthenticatePackageGenerationRejectsStalePackages(t *testing.T) {
|
||||
|
||||
func TestLoadPackageConfigFromEnv(t *testing.T) {
|
||||
path := writePackageConfig(t, PackageConfig{
|
||||
Kind: PackageComponentClientManager,
|
||||
Kind: PackageComponentRun,
|
||||
ServerInstanceID: "server-1",
|
||||
PluginID: "game.scum",
|
||||
ProfileKey: "scum-client-manager",
|
||||
RunEndpointID: "run-server-1",
|
||||
ProfileKey: "run-local",
|
||||
TargetOS: "windows",
|
||||
TargetArch: "amd64",
|
||||
SecretRef: "secret://runtime-keys/server-1/client-manager/scum-client-manager/current",
|
||||
SecretRef: "secret://runtime-keys/server-1/run/current",
|
||||
KeyGeneration: 4,
|
||||
AuthKey: "opaque-client-key",
|
||||
AuthKey: "opaque-run-key",
|
||||
})
|
||||
t.Setenv(PackageConfigEnv, path)
|
||||
|
||||
@@ -118,7 +134,7 @@ func TestLoadPackageConfigFromEnv(t *testing.T) {
|
||||
if err != nil || !ok {
|
||||
t.Fatalf("expected env package config, ok=%v err=%v", ok, err)
|
||||
}
|
||||
if cfg.Kind != PackageComponentClientManager || cfg.ProfileKey != "scum-client-manager" {
|
||||
if cfg.Kind != PackageComponentRun || cfg.ProfileKey != "run-local" {
|
||||
t.Fatalf("unexpected package config: %+v", cfg)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user